Skip to content

Pin arrow-rs and DataFusion at their landed spiceai merges - #70

Merged
krinart merged 2 commits into
spiceai-55-patches-2from
viktor/df55-att2/arrow-spiceai-59
Oct 2, 2026
Merged

krinart merged 2 commits into
spiceai-55-patches-2from
viktor/df55-att2/arrow-spiceai-59

Conversation

@krinart

@krinart krinart commented Oct 2, 2026 •

Copy link
Copy Markdown

Moves the fork pins to landed revisions, so this fork builds against what Spice pins (spiceai/spiceai#14612):

Copilot AI balanced review requested due to automatic review settings October 2, 2026 01:25
Copilot AI previously approved these changes Oct 2, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approved

The manifest and lockfile pins are complete, consistent, and match the landed Spice revision.

Review effort: Balanced
Findings: None

What changed in this PR

Updates Ballista’s Arrow fork pin to match the revision used by Spice.

Changes:

  • Pins all Arrow and Parquet patches to 2e2cc330.
  • Synchronizes corresponding lockfile sources.
File Description
Cargo.toml Updates Arrow fork revisions and branch annotations.
Cargo.lock Records the new revision for all affected packages.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Copilot AI balanced review requested due to automatic review settings October 2, 2026 03:43
@krinart krinart changed the title Pin arrow-rs at the spiceai-59 merge (2e2cc330) Pin arrow-rs and DataFusion at their landed spiceai merges Oct 2, 2026
Copilot AI dismissed their stale review, a newer Copilot review was requested October 2, 2026 03:43

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approved

The manifest and lockfile consistently use the verified landed merge revisions with no stale pins remaining.

Review effort: Balanced
Findings: None

@krinart
krinart merged commit e339182 into spiceai-55-patches-2 Oct 2, 2026
27 of 29 checks passed
@krinart
krinart deleted the viktor/df55-att2/arrow-spiceai-59 branch October 2, 2026 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants