You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Fixes "Tests (default)" on #50. That job fails in make docker-up before any test runs:
mc Error pull access denied for minio/mc, repository does not exist or may require 'docker login'
make: *** [Makefile:110: docker-up] Error 1
(job 110117449151). The images are gone from both registries, so this is an environment break that affects every branch, not something the DataFusion 55 changes caused:
docker manifest inspect minio/mc:RELEASE.2025-05-21T01-59-54Z / minio/minio:RELEASE.2025-05-24T17-08-30Z -> denied: requested access to the resource is denied
docker manifest inspect rustfs/rustfs:1.0.0 -> OCI index returned
This backports upstream apache#3273 (119fad9), which swaps MinIO for RustFS and renames the test helpers and ICEBERG_TEST_MINIO_ENDPOINT to the object-store names. The only conflict, in dev/docker-compose.yaml, was resolved to the RustFS side, keeping this line's REST fixture CATALOG_URI. git grep -i minio finds nothing left outside docs and the opendal minio:// scheme support.
Once the RustFS swap was in place, the first CI run on this PR (job 110224388762) got past the MinIO pulls and failed on the next environmental break in make docker-up: the HMS image build runs apt-get install curl on the Debian 11 base of apache/hive:3.1.3, and Debian's mirrors no longer have those package versions:
E: Failed to fetch http://deb.debian.org/debian-security/pool/updates/main/c/curl/curl_7.74.0-1.3%2bdeb11u16_amd64.deb 404 Not Found
target hive-metastore: failed to solve
The second commit backports upstream apache#3174 (4687d26). It fetches the two jars with checksum-pinned ADD instead of installing curl.
Neither commit was run locally (the build host has no Docker daemon). This PR's own "Tests (default)" run is the check.
Backport of apache#3273 (119fad9). Docker Hub no longer serves
minio/mc or minio/minio, and quay.io/minio no longer allows anonymous pulls, so
`make docker-up` fails before any integration test runs. Conflict in
dev/docker-compose.yaml resolved to the RustFS services, keeping this line's
REST fixture CATALOG_URI.
(cherry picked from commit 119fad9)
krinart
changed the title
ci: replace MinIO with RustFS for integration tests (backport #3273)
ci: unbreak docker-up (backport #3273 RustFS swap and #3174 HMS jar ADD)
Oct 1, 2026
The reason will be displayed to describe this comment to others. Learn more.
Copilot review overview
🔵 Needs a closer look
The documented direct Compose commands do not remove renamed MinIO orphan containers, potentially leaving port 9000 occupied.
Review effort: Balanced Findings: None
Previously missed (1)
In code that hasn't changed since last review
Add orphan removal to direct start/stop commands
dev/docker-compose.yaml:31
The service rename makes the direct start/stop commands at lines 20–21 stale. Unlike the updated Make targets, they do not remove the old minio/mc orphan containers; an existing minio container can retain port 9000 and prevent object-store from starting. Add --remove-orphans to both documented commands so the advertised workflow handles this migration too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes "Tests (default)" on #50. That job fails in
make docker-upbefore any test runs:(job 110117449151). The images are gone from both registries, so this is an environment break that affects every branch, not something the DataFusion 55 changes caused:
docker manifest inspect minio/mc:RELEASE.2025-05-21T01-59-54Z/minio/minio:RELEASE.2025-05-24T17-08-30Z->denied: requested access to the resource is denieddocker manifest inspect quay.io/minio/{minio,mc}:<same tags>(upstream's first workaround, ci: pull MinIO images from Quay apache/iceberg-rust#3202) ->no such manifestdocker manifest inspect rustfs/rustfs:1.0.0-> OCI index returnedThis backports upstream apache#3273 (119fad9), which swaps MinIO for RustFS and renames the test helpers and
ICEBERG_TEST_MINIO_ENDPOINTto the object-store names. The only conflict, indev/docker-compose.yaml, was resolved to the RustFS side, keeping this line's REST fixtureCATALOG_URI.git grep -i miniofinds nothing left outside docs and the opendalminio://scheme support.Once the RustFS swap was in place, the first CI run on this PR (job 110224388762) got past the MinIO pulls and failed on the next environmental break in
make docker-up: the HMS image build runsapt-get install curlon the Debian 11 base ofapache/hive:3.1.3, and Debian's mirrors no longer have those package versions:The second commit backports upstream apache#3174 (4687d26). It fetches the two jars with checksum-pinned
ADDinstead of installing curl.Neither commit was run locally (the build host has no Docker daemon). This PR's own "Tests (default)" run is the check.