fix: Enable CGO in Makefile build target for SQLite support#18
Open
spideyz0r wants to merge 1 commit into
Open
fix: Enable CGO in Makefile build target for SQLite support#18spideyz0r wants to merge 1 commit into
spideyz0r wants to merge 1 commit into
Conversation
The go-sqlite3 library requires CGO to be enabled to work properly. Without CGO_ENABLED=1, the binary fails at runtime with: "Binary was compiled with 'CGO_ENABLED=0', go-sqlite3 requires cgo to work" This change enables CGO during the build process, allowing SQLite to function correctly when running 'fh --init' and other database operations. Note: Users building from source will now need a C compiler (gcc, Xcode command-line tools, etc.) installed. Pre-built binaries are not affected as SQLite is statically linked at build time. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR partially addresses SQLite's CGO requirement by enabling CGO for the Makefile's build target. The change allows local development builds to work with the go-sqlite3 driver, which is used throughout the project for database operations (see pkg/storage/).
Key Changes:
- Enable CGO during Makefile build process by setting
CGO_ENABLED=1
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The go-sqlite3 library requires CGO to be enabled to work properly. Without CGO_ENABLED=1, the binary fails at runtime with: "Binary was compiled with 'CGO_ENABLED=0', go-sqlite3 requires cgo to work"
This change enables CGO during the build process, allowing SQLite to function correctly when running 'fh --init' and other database operations.
Note: Users building from source will now need a C compiler (gcc, Xcode command-line tools, etc.) installed. Pre-built binaries are not affected as SQLite is statically linked at build time.
🤖 Generated with Claude Code