Skip to content

modules(db): only surface async methods #146

Description

@vdice

The Spin 4.0.0-updated db modules, sqlite and postgres (mysql still awaits), currently expose both the synchronous and asynchronous methods of interaction (eg execute and execute_async) directly from the underlying wits (https://github.com/spinframework/spin-python-sdk/blob/main/src/spin_sdk/wit/imports/spin_sqlite_sqlite_3_1_0.py and https://github.com/spinframework/spin-python-sdk/blob/main/src/spin_sdk/wit/imports/spin_postgres_postgres_4_2_0.py, respectively).

It has been suggested that the modules prioritize the async variants (eg by mapping execute to the underlying execute_async import)

Be sure to update associated Spin v4 docs to suit (eg https://spinframework.dev/v4/sqlite-api-guide and https://spinframework.dev/v4/rdbms-storage)

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions