Return visible errors for unsupported Notion content#133
Open
cwjcwj95 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.notion-errormessage for unsupported Notion block types instead of silently returning an empty<div />.collection_viewblock is present but no collection data is available.Why
Fixes #87.
Before this change, unsupported content such as a Notion database could make the page appear to not load, especially in production where the existing unsupported-type log is not visible to users. The renderer now explains which unsupported content should be removed.
Verification
tscoutput with a baseline copy of currentmaster; both show the same existing TypeScript environment errors:processtype under the constrained--types react,react-domcheckcustomBlockComponentsnevernarrowing errorNote: a full install using the repository's old
typescript@3.9currently resolves newer@types/*packages from npm, which produce dependency syntax errors unrelated to this patch.