Skip to content

Fix test assertion for paginated results #331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
michael-burt wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix test assertion for paginated results #331

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dd5562b
Fix test assertion for paginated results
michael-burt Apr 14, 2025
430a2cc
Fix pagination test: use string continue token and restore fatal asse…
michael-burt Jun 12, 2026
6d2a661
Clean up pagination test helpers
michael-burt Jun 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions internal/remote/query_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,16 +30,15 @@ import (
"k8s.io/kubectl/pkg/scheme"
)

func newUnstructuredList(apiVersion, kind string, continueVal int64, items ...*unstructured.Unstructured) *unstructured.UnstructuredList {
func newUnstructuredList(apiVersion, kind string, continueVal string, items ...*unstructured.Unstructured) *unstructured.UnstructuredList {
list := &unstructured.UnstructuredList{
Object: map[string]interface{}{
"apiVersion": apiVersion,
"kind": kind,
"metadata": map[string]interface{}{
"continue": continueVal,
},
"metadata": map[string]interface{}{},
},
}
list.SetContinue(continueVal)
for i := range items {
list.Items = append(list.Items, *items[i])
}
Expand Down Expand Up @@ -74,7 +73,7 @@ func TestListPagination(t *testing.T) {
tf.FakeDynamicClient = dynamicfakeclient.NewSimpleDynamicClientWithCustomListKinds(scheme.Scheme, listMapping)
var uns []*unstructured.Unstructured
var totalItemsInList = int64(3)
for i := int64(0); i <= totalItemsInList; i++ {
for i := int64(0); i < totalItemsInList; i++ {
ns := "default"
uns = append(uns, newUnstructured("v1", "Secret", ns, fmt.Sprintf("test-secret-%d", i)))
}
Expand All @@ -83,7 +82,11 @@ func TestListPagination(t *testing.T) {
if callIndex >= totalItemsInList {
return true, nil, errors.New("unexpected call to list. list has been served already")
}
listWithContinue := newUnstructuredList("v1", "SecretList", totalItemsInList-callIndex-1, uns[callIndex])
continueToken := ""
if callIndex+1 < totalItemsInList {
continueToken = fmt.Sprintf("page-%d", callIndex+1)
}
listWithContinue := newUnstructuredList("v1", "SecretList", continueToken, uns[callIndex])
callIndex++
return true, listWithContinue, nil
})
Expand Down Expand Up @@ -111,7 +114,6 @@ func TestListPagination(t *testing.T) {
}
actual := len(objs)
if int(totalItemsInList) != actual {
t.Logf("expected items to be %d but found %d. Change this to Fatal when https://github.com/kubernetes/kubernetes/issues/107277 is fixed", totalItemsInList, actual)
// t.Fatalf("expected items to be %d but found %d", totalItemsInList, actual)
t.Fatalf("expected items to be %d but found %d", totalItemsInList, actual)
}
}
Loading