SYN-6725: Add Validate support for Synthetics test definitions - #52
Draft
jcsco wants to merge 1 commit into
Draft
Conversation
Adds ValidateNew*/Validate* client methods for API, Browser, HTTP (including nullable-port variants), Port, and SSL v2 test checks, covering both create-style and update-style validation against the Synthetics API's validate endpoints. Validation never saves a test or triggers a run. ValidateResponse.FieldErrors() normalizes the API's validate response, which returns an empty array for details on success and an object of per-attribute error messages on failure.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ValidateNew*/Validate*client methods tosyntheticsclientv2for API, Browser, HTTP (including nullable-port variants), Port, and SSL v2 test checks, covering both create-style (POST .../validate) and update-style (PUT .../{id}/validate) validation flows against the Synthetics API's test validate endpoints.ValidateResponsetype with aFieldErrors()helper that normalizes the API'sdetailsfield, which is an empty array on success and an object of per-attribute error messages on failure.SslCheckV2UpdateInput(matchingUpdateSslCheckV2's partial-update semantics) while SSL create-style validation takesSslCheckV2Input.Jira: SYN-6725
Test plan
go build ./...go test -tags unit_tests ./...— full suite passes, including new tests covering both success and field-level-error validation responses for every supported type/flow