SYN-6813: add GetChromeFlags() to fetch chrome_flags endpoint - #54
Merged
Conversation
Wires up the existing ChromeFlagsResponse struct as the first caller, following the GetExcludedFileTypesV2 pattern.
jcsco
requested review from
etipton-splunk and
jinja2
and removed request for
a team
August 12, 2026 01:05
Follows the TestLiveGetExcludedFileTypesV2 pattern for a no-args live GET endpoint.
|
Code Coverage Report: |
…hape The GET /chrome_flags endpoint returns a catalog of supported flags (name, label, description, acceptsValue), not name/value pairs set on a check. Introduce ChromeFlagOption for that shape and use it in ChromeFlagsResponse, leaving ChromeFlag (used for a check's configured advancedSettings.chromeFlags) untouched.
Integration Test: ✅ PassedLive integration tests — Total: 60 | Passed: 60 | Failed: 0 | Skipped: 0
|
bchhay-splunk
approved these changes
Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GetChromeFlags()insyntheticsclientv2that callsGET /chrome_flagsand returns the existingChromeFlagsResponsestruct (previously dead code), following theGetExcludedFileTypesV2single-GET pattern.This is a prerequisite for wiring up a
synthetics_chrome_flagsdata source in terraform-provider-synthetics (SYN-6813), which will land once this client change is released.Test plan
go test ./syntheticsclientv2/... -run ChromeFlags -vpassesgo build ./...andgo vet ./...cleanJira: https://splunk.atlassian.net/browse/SYN-6813