refactor: remove sector, use segments directly instead#35
Merged
Conversation
…e into refactor/remove-sectors
aarjn
pushed a commit
to aarjn/tape
that referenced
this pull request
Sep 2, 2025
* remove sector, use segments directly instead * initial replacement of crazy fetch * update to memory based packx * fix for slow test * fixed re-sync and get-tape from snapshot * more packed tape fixes * clippy fixes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the sector type as a result of #34
The code is far cleaner, the minor db savings are not worth the complexity at the moment.