Add support for more generic resolver #118
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,45 @@ | ||
| /* | ||
| * Copyright (c) 2019 Spotify AB | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); you may not | ||
| * use this file except in compliance with the License. You may obtain a copy of | ||
| * the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT | ||
| * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the | ||
| * License for the specific language governing permissions and limitations under | ||
| * the License. | ||
| */ | ||
| package com.spotify.folsom; | ||
|
|
||
| import com.google.common.collect.ImmutableList; | ||
| import com.spotify.folsom.guava.HostAndPort; | ||
| import java.util.List; | ||
|
|
||
| public class ConstantResolver implements Resolver { | ||
| private final ImmutableList<ResolveResult> results; | ||
|
|
||
| public ConstantResolver(ImmutableList<ResolveResult> results) { | ||
| this.results = results; | ||
| } | ||
|
|
||
| static ConstantResolver fromAddresses(List<HostAndPort> addresses) { | ||
| final long ttl = Long.MAX_VALUE; // can use a very long TTL since the resolver is constant | ||
| final ImmutableList<ResolveResult> results = | ||
| addresses | ||
| .stream() | ||
| .map( | ||
| hostAndPort -> | ||
| new ResolveResult(hostAndPort.getHostText(), hostAndPort.getPort(), ttl)) | ||
| .collect(ImmutableList.toImmutableList()); | ||
| return new ConstantResolver(results); | ||
| } | ||
|
|
||
| @Override | ||
| public List<ResolveResult> resolve() { | ||
| return results; | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| /* | ||
| * Copyright (c) 2019 Spotify AB | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); you may not | ||
| * use this file except in compliance with the License. You may obtain a copy of | ||
| * the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT | ||
| * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the | ||
| * License for the specific language governing permissions and limitations under | ||
| * the License. | ||
| */ | ||
|
|
||
| package com.spotify.folsom; | ||
|
|
||
| import java.util.List; | ||
|
|
||
| public interface Resolver { | ||
|
|
||
| class ResolveResult { | ||
| private final String host; | ||
| private final int port; | ||
| private final long ttl; | ||
|
|
||
| public ResolveResult(String host, int port, long ttl) { | ||
| this.host = host; | ||
| this.port = port; | ||
| this.ttl = ttl; | ||
| } | ||
|
|
||
| public String getHost() { | ||
| return host; | ||
| } | ||
|
|
||
| public int getPort() { | ||
| return port; | ||
| } | ||
|
|
||
| public long getTtl() { | ||
| return ttl; | ||
| } | ||
| } | ||
|
|
||
| List<ResolveResult> resolve(); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| package com.spotify.folsom.ketama; | ||
|
|
||
| import com.google.common.collect.Lists; | ||
| import com.spotify.dns.DnsSrvResolver; | ||
| import com.spotify.dns.LookupResult; | ||
| import com.spotify.folsom.Resolver; | ||
| import java.util.List; | ||
|
|
||
| public class SrvResolver implements Resolver { | ||
|
|
||
| private final DnsSrvResolver srvResolver; | ||
| private final String srvRecord; | ||
|
|
||
| public SrvResolver(DnsSrvResolver srvResolver, String srvRecord) { | ||
| this.srvResolver = srvResolver; | ||
| this.srvRecord = srvRecord; | ||
| } | ||
|
|
||
| @Override | ||
| public List<ResolveResult> resolve() { | ||
| List<LookupResult> lookupResults = srvResolver.resolve(srvRecord); | ||
| List<ResolveResult> results = Lists.newArrayListWithCapacity(lookupResults.size()); | ||
| for (LookupResult lookupResult : lookupResults) { | ||
| results.add(new ResolveResult(lookupResult.host(), lookupResult.port(), lookupResult.ttl())); | ||
| } | ||
| return results; | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I screwed with this one, but this change is no longer needed