Ak/fix train feeding#5
Open
AlexeyKruglov wants to merge 3 commits into
Open
Conversation
AlexeyKruglov
commented
Nov 19, 2017
- Fix index out of range error.
- About 8x (for me) training speed-up by feeding whole sample sequence through CuDNN, not char-by-char.
- Inference: GPU memory requirement not growing with generated seq length anymore -- by dropping Variable history in inference.
... by feeding the whole sequence to CuDNN RNN, as opposed to character-by-character.
|
For what it's worth, using the pre-built pytorch 1.3 on macOS (where CUDA is not available), on an early-2015 MacBook Pro, this patch doesn't seem to improve performance on CPU-- instead, it makes training more than twice as slow. [Edited to add: Tested with CPU on Linux, and got similar results there as well.] After 100 iterations using the default hyperparameters: Not sure whether this is an issue with this specific CPU, an inefficiency in PyTorch itself, or something that could be further improved in the char-rnn code, but it's definitely worth pointing out either way. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.