Refactor to allow for non-ASCII data#8
Open
codeman38 wants to merge 1 commit into
Open
Conversation
This modifies the read_file method to extract the character vocabulary from the input file, which is then passed as an argument to the generate and char_tensor methods. This also modifies the output file format to include the vocabulary. generate.py will parse this format by default, but fall back to string.printable if it's unable to read a vocabulary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This modifies the
read_filemethod to extract the character vocabulary from the input file, which is then passed as an argument to thegenerateandchar_tensormethods.This also modifies the output file format to include the vocabulary.
generate.pywill parse this format by default, but fall back tostring.printableif it's unable to read a vocabulary.