Skip to content
This repository was archived by the owner on Apr 19, 2024. It is now read-only.

Updated Node.md#74

Open
mrkevinjmiller wants to merge 2 commits intospruceid:mainfrom
mrkevinjmiller:JavaScript-doc-update-kevinmiller
Open

Updated Node.md#74
mrkevinjmiller wants to merge 2 commits intospruceid:mainfrom
mrkevinjmiller:JavaScript-doc-update-kevinmiller

Conversation

@mrkevinjmiller
Copy link

Reworded some sections for clarity
Added npm wasm-node installation example
Updated code example to work with wasm-node
Removed reverences to didkit-neon as I could not find a package by this name to install via npm.

Reworded some sections for clarity
Added npm installation example
Updated code example to work with wasm-node
Removed reverences to didkit-neon as I could not find a package by this name to install via npm.

- [WASM](https://github.com/spruceid/didkit/tree/main/lib/web)
- [Neon](https://github.com/spruceid/didkit/tree/main/lib/node)
- [WASm-node](https://github.com/spruceid/didkit/tree/main/lib/node)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could there be some confusion around the Neon version and the node specific WASM package?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could only find 2 versions to install via npm, the WASM version, and the node specific version. I could not find a third neon version to install.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sbihel. I tried to install it via 'npm install @spruceid/didkit' and got errors. Attached is the npm error log. I don't have time at the moment to debug, but will look when I get a chance. Am open to ideas/suggestions. TIA
2022-03-09T21_53_08_161Z-debug-0.log

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, looks like the Neon version doesn't support Windows. I think you can drop the PR for now, we'll have to decide internally what to do with the Neon version and the other packages.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I'll try it out on Windows WSL also when I get a chance. See if I get the same/similar errors.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also go errors when trying to install "@spruceid/didkit" on Windows WSL (Ubuntu). I think I'll make one more update to Node,md to clarify what works on Linux and what works on Windows.

Fixed example JavaScrip code to properly handle the promise returned by keyToVerificationMethod.
Also fixed minor typo in ## Code section
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants