feat(ios) Accessibility Deferral Element and additions by RoyalPineapple · Pull Request #598 · square/Blueprint

RoyalPineapple · 2025-11-12T12:33:46Z

Summary

This PR enhances the accessibility deferral system with comprehensive improvements to frame handling and element composition.

Key Changes

ReceiverContainer Element: Introduces AccessibilityDeferral.ReceiverContainer allowing arbitrary elements to receive deferred accessibility content without needing to conform to the AccessibilityDeferral.Receiver protocol directly
FrameProvider: Adds centralized accessibility frame handling with support for both CGRect-based and UIView-based frame providers, including automatic corner radius support
Accessibility Merging: Implements merge() method on CompositeRepresentation to combine accessibility values from multiple sources
Protocol Updates: Updates Receiver protocol with updateDeferredAccessibility(frameProvider:) callback for frame-aware receivers
CombinableView changes: Makes CombinableView extensible (changed from final class) and adds mergeValues property for more flexible accessibility composition

Technical Details

The FrameProvider struct provides a unified API for accessibility frame handling that enables UIView-based frame passthrough without taking a strong reference to the backing view.

The ReceiverContainer wraps any element and handles deferred accessibility application automatically, simplifying the integration of accessibility deferral in complex element hierarchies.

BlueprintUIAccessibilityCore/Sources/AccessibilityComposition.swift

BlueprintUIAccessibilityCore/Sources/AccessibilityDeferral.swift

BlueprintUIAccessibilityCore/Sources/AccessibilityComposition.swift

RoyalPineapple · 2026-01-29T11:22:30Z

BlueprintUIAccessibilityCore/Sources/AccessibilityDeferral.swift


-        func replaceContent(_ content: [AccessibilityDeferral.Content]?) {
-            deferredAccessibilityContent = content
+    internal func replaceContent(_ content: [AccessibilityDeferral.Content]?) {


moving this internal as it doesn't need to be the responsibility of the consumer and this removes some foot guns

… element This introduces comprehensive accessibility deferral improvements: - Add ReceiverContainer element to expose deferred accessibility content - Add FrameProvider to centralize accessibility frame handling - Add merge() method to combine accessibility representations - Apply container frames and corner radius to accessibility paths - Refactor Receiver protocol with updateDeferredAccessibility callback - Make CombinableView extensible and add mergeValues support - Update array extensions to package visibility Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

RoyalPineapple · 2026-01-29T15:24:08Z

BlueprintUIAccessibilityCore/Sources/AccessibilityDeferral.swift


        /// Custom content that may be supplied in addition to the deferred content
-        var customContent: [Accessibility.CustomContent]? { get set }
+        var customContent: [BlueprintUI.Accessibility.CustomContent]? { get set }


not sure we need this

Yeah I think kill it

johnnewman-square

These changes look good. I'm going to give the Market integration a pass and will circle back.

I think it would be great if we could add new unit tests for these deferral updates, if possible.

johnnewman-square · 2026-03-02T18:30:53Z

BlueprintUIAccessibilityCore/Sources/AccessibilityDeferral.swift

+                    mergeValues = deferred.dropFirst()
+                        .reduce(into: first) { result, value in
+                            result.merge(with: value)
+                        }


Will the result of result.merge(with: value) be discarded here? I wonder if we could tweak this reduce pattern just a bit and add a unit test that captures this particular flow.

johnnewman-square · 2026-03-02T18:36:04Z

BlueprintUIAccessibilityCore/Sources/AccessibilityDeferral.swift

+
+    /// Creates a `ReceiverContainer` element to expose the deferred accessibility.
+    public func deferredAccessibilityReceiver(identifiers: [AnyHashable]) -> AccessibilityDeferral.ReceiverContainer {
+        AccessibilityDeferral.ReceiverContainer(wrapping: { self })
+    }


Could we update this function to use or remove the identifiers parameter?

johnnewman-square · 2026-03-02T18:51:32Z

BlueprintUIAccessibilityCore/Sources/AccessibilityDeferral.swift

+                            result.merge(with: value)
+                        }
+                }
+                needsAccessibilityUpdate = true


There are two calls to needsAccessibilityUpdate = true in this function. Could we remove one?

johnnewman-square · 2026-03-02T18:51:59Z

BlueprintUIAccessibilityCore/Sources/AccessibilityDeferral.swift

        public var sourceIdentifier: AnyHashable

-        /// : A stable identifier used to identify a given update pass through he view hierarchy. Content with matching updateIdentifiers should be combined.
+        /// A stable identifier used to identify a given update pass through he view hierarchy. Content with matching updateIdentifiers should be combined.


Suggested change

/// A stable identifier used to identify a given update pass through he view hierarchy. Content with matching updateIdentifiers should be combined.

/// A stable identifier used to identify a given update pass through the view hierarchy. Content with matching updateIdentifiers should be combined.

soroushsq · 2026-03-02T21:18:58Z

BlueprintUIAccessibilityCore/Sources/AccessibilityDeferral.swift


        /// Custom content that may be supplied in addition to the deferred content
-        var customContent: [Accessibility.CustomContent]? { get set }
+        var customContent: [BlueprintUI.Accessibility.CustomContent]? { get set }


Yeah I think kill it

soroushsq · 2026-03-02T21:20:20Z

BlueprintUIAccessibilityCore/Sources/AccessibilityDeferral.swift

+        ///   - cornerRadius: The radius for rounded corners
+        public static func frame(_ rect: CGRect, cornerRadius: CGFloat = accessibilityCornerRadius) -> Self {
+            .init {
+                UIBezierPath(roundedRect: rect, cornerRadius: max(0, cornerRadius + accessibilityPathInset))


Can this really be negative?

RoyalPineapple changed the base branch from main to alex/migrateA11y November 12, 2025 12:34

RoyalPineapple force-pushed the alex/migrateA11y branch from 3511a17 to 9d4dd5b Compare November 20, 2025 10:51

Base automatically changed from alex/migrateA11y to main November 25, 2025 12:14

RoyalPineapple force-pushed the alex/labelDeferral branch from fe80b79 to 3eb1400 Compare December 9, 2025 13:14

RoyalPineapple force-pushed the alex/labelDeferral branch 3 times, most recently from 80b442d to 025d5b2 Compare December 16, 2025 19:06

RoyalPineapple commented Dec 16, 2025

View reviewed changes

BlueprintUIAccessibilityCore/Sources/AccessibilityComposition.swift Outdated Show resolved Hide resolved

RoyalPineapple commented Dec 16, 2025

View reviewed changes

BlueprintUIAccessibilityCore/Sources/AccessibilityComposition.swift Outdated Show resolved Hide resolved

RoyalPineapple commented Dec 16, 2025

View reviewed changes

BlueprintUIAccessibilityCore/Sources/AccessibilityComposition.swift Show resolved Hide resolved

RoyalPineapple force-pushed the alex/labelDeferral branch from e1e19d9 to c94d466 Compare January 27, 2026 16:39

RoyalPineapple changed the title ~~[WIP DNR] Alex/label deferral~~ [WIP DNR] Accessibility Deferral element Jan 28, 2026

RoyalPineapple commented Jan 28, 2026

View reviewed changes

BlueprintUIAccessibilityCore/Sources/AccessibilityDeferral.swift Outdated Show resolved Hide resolved

RoyalPineapple commented Jan 28, 2026

View reviewed changes

BlueprintUIAccessibilityCore/Sources/AccessibilityDeferral.swift Outdated Show resolved Hide resolved

RoyalPineapple commented Jan 28, 2026

View reviewed changes

BlueprintUIAccessibilityCore/Sources/AccessibilityDeferral.swift Outdated Show resolved Hide resolved

RoyalPineapple commented Jan 28, 2026

View reviewed changes

BlueprintUIAccessibilityCore/Sources/AccessibilityComposition.swift Outdated Show resolved Hide resolved

RoyalPineapple force-pushed the alex/labelDeferral branch 2 times, most recently from a4cc843 to ee29332 Compare January 29, 2026 11:17

RoyalPineapple commented Jan 29, 2026

View reviewed changes

RoyalPineapple force-pushed the alex/labelDeferral branch 2 times, most recently from 72fcecd to 9ce750c Compare January 29, 2026 15:17

RoyalPineapple force-pushed the alex/labelDeferral branch from 9ce750c to d3c997d Compare January 29, 2026 15:19

RoyalPineapple commented Jan 29, 2026

View reviewed changes

RoyalPineapple changed the title ~~[WIP DNR] Accessibility Deferral element~~ feat(ios) Accessibility Deferral Element and additions Jan 29, 2026

Update BlueprintUIAccessibilityCore/Sources/AccessibilityDeferral.swift

f5a29e8

RoyalPineapple marked this pull request as ready for review March 2, 2026 12:33

RoyalPineapple requested a review from a team as a code owner March 2, 2026 12:33

johnnewman-square reviewed Mar 2, 2026

View reviewed changes

soroushsq approved these changes Mar 2, 2026

View reviewed changes

	/// A stable identifier used to identify a given update pass through he view hierarchy. Content with matching updateIdentifiers should be combined.
	/// A stable identifier used to identify a given update pass through the view hierarchy. Content with matching updateIdentifiers should be combined.

Conversation

RoyalPineapple commented Nov 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Key Changes

Technical Details

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

johnnewman-square left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

RoyalPineapple commented Nov 12, 2025 •

edited

Loading