fix hang caused by Gtk3 -init breaking float arithmetic in non-C locales#264
Open
bor wants to merge 1 commit intosquentin:masterfrom
Open
fix hang caused by Gtk3 -init breaking float arithmetic in non-C locales#264bor wants to merge 1 commit intosquentin:masterfrom
bor wants to merge 1 commit intosquentin:masterfrom
Conversation
Gtk3's gtk_init() calls setlocale(LC_ALL, "") which sets LC_NUMERIC to the user's locale. In locales using comma as decimal separator (e.g. uk_UA.UTF-8), this causes Perl to misinterpret float literals like .8 as 0, making Breakdown_List loop infinitely with $max=0. use locale :numeric tells Perl to properly manage LC_NUMERIC, keeping C locale for arithmetic while respecting user locale for display. Resolves squentin#253
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gtk3's gtk_init() calls setlocale(LC_ALL, "") which sets LC_NUMERIC to the user's locale. In locales using comma as decimal separator (e.g. uk_UA.UTF-8), this causes Perl to misinterpret float literals like .8 as 0, making Breakdown_List loop infinitely with $max=0.
use locale :numeric tells Perl to properly manage LC_NUMERIC, keeping C locale for arithmetic while respecting user locale for display.
Resolves #253