fix missing icons on icon themes without deprecated gtk-* stock names#265
Open
bor wants to merge 1 commit intosquentin:masterfrom
Open
fix missing icons on icon themes without deprecated gtk-* stock names#265bor wants to merge 1 commit intosquentin:masterfrom
bor wants to merge 1 commit intosquentin:masterfrom
Conversation
Modern icon themes (Adwaita 48+) no longer provide gtk-* stock icon names. Add fallback mappings from deprecated gtk2 stock IDs to their freedesktop standard equivalents (e.g. gtk-media-play to media-playback-start). The mappings are only used when the old names are not found in the current theme, so bundled gmusicbrowser themes that ship their own gtk-*.png files continue to work as before. Also fix search entry icons which used set_icon_from_stock directly instead of going through check_icon_name. Related to squentin#57, squentin#177
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modern icon themes (Adwaita 48+) no longer provide gtk-* stock icon names. Add fallback mappings from deprecated gtk2 stock IDs to their freedesktop standard equivalents (e.g. gtk-media-play to media-playback-start). The mappings are only used when the old names are not found in the current theme, so bundled gmusicbrowser themes that ship their own gtk-*.png files continue to work as before.
Also fix search entry icons which used set_icon_from_stock directly instead of going through check_icon_name.
Related to #57, #177