Improve venv resolution for cross-platform test compatibility#51
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Scripts/python.exeorbin/python, and the code assumed a single layout.Description
venv_pythonto compute bothScripts/python.exeandbin/python, preferring the OS-native location but falling back to the alternate when present.find_venvselection logic unchanged while making interpreter existence checks resilient to both layouts.subprocess.callinrun_pyby usingas_posix()for consistent argument formatting across platforms.Testing
pytest -q tests/test_venv.py tests/test_cli.py::test_doctor_reports_detected_venv tests/test_cli.py::test_doctor_reports_missing_venv_with_hintand the targeted tests passed.pytest -qand all tests passed (91 passed).Codex Task