Handle Unicode-unsafe terminals in CLI success output#53
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
UnicodeEncodeErroron terminals that can't encode emoji (e.g., Windows cp1252), causingdevr checkto crash after tests.Description
_echo_with_fallback(primary, fallback)insrc/devr/cli.pythat callstyper.echo(primary)and falls back to ASCII-safe text when aUnicodeEncodeErroris raised.check,fix, andsecuritywith_echo_with_fallback(...)using plain-text fallbacks.test_echo_with_fallback_uses_plaintext_when_unicode_encoding_failsintests/test_cli.pythat simulates an encoding failure and asserts the fallback is used.Testing
pytest -q, which passed:92 passed in 0.79s.typer.echoencoding failure also passed as part of the test run.Codex Task