Add 5528.xml and 5630.xml - #1389
Conversation
wlpotter
left a comment
wlpotter
left a comment
There was a problem hiding this comment.
Great work @helenelrey ! Left some in-line comments. Please let me know if I can clarify any of them further.
| <text> | ||
| <body> | ||
| <bibl xml:id="work-5528" type="lawd:ConceptualWork"> | ||
| <title xml:id="name5528-1" xml:lang="en" srophe:tags="#syriaca-headword">Ethikon</title> |
There was a problem hiding this comment.
Work titles should have either a source attribute pointing to a bibl xml:id, or a resp="http://syriaca.org" attribute
There was a problem hiding this comment.
would it be possible to add this requirement to the template?
There was a problem hiding this comment.
Yes, great idea -- I have updated the template to include a source attribute and comment with instructions to fill it out or replace with a resp
| <title xml:id="name5528-1" xml:lang="en" srophe:tags="#syriaca-headword">Ethikon</title> | ||
| <title xml:id="name5528-2" xml:lang="syr" srophe:tags="#syriaca-headword">ܟܬܒܐ ܕܐܝܬܝܩܘܢ</title> | ||
| <title xml:id="name5528-3" xml:lang="en">Ethicon</title> | ||
| <author ref="https://syriaca.org/person/239" xml:lang="en">Gregorius bar Hebraeus — <foreign xml:lang="syr">ܓܪܝܓܘܪܝܘܣ ܒܪ ܥܒܪܝܐ</foreign> |
There was a problem hiding this comment.
Careful of "https" vs "http", Syriaca URIs should use "http".
Also, authors should have either source or resp attributes, similar to titles
| <desc xml:lang="en">This is not a comprehensive list of editions related to this work. Further citations may be available through <ref target="http://syriaca.org/cbss">The Comprehensive Bibliography on Syriac Studies</ref>.</desc> | ||
| <bibl xml:id="bib5528-1" type="lawd:Edition"> | ||
| <title xml:lang="la">Ethicon; seu, Moralia Gregorii Barhebraei</title> | ||
| <ptr target="https://syriaca.org/cbss/82QM9R5K"/> |
There was a problem hiding this comment.
flagging the https, which should be http
| <desc xml:lang="en">This is not a comprehensive list of secondary literature related to this work. Further citations may be available through <ref target="http://syriaca.org/cbss">The Comprehensive Bibliography on Syriac Studies</ref>.</desc> | ||
| <bibl type="lawd:Citation" xml:id="bib5528-3"> | ||
| <title xml:lang="la">Bibliothecæ Apostolicæ Vaticanæ codicum manuscriptorum catalogus. Partis primæ, tomus tertius, complectens reliquos codices chaldaicos sive syriacos</title> | ||
| <ptr target="https://syriaca.org/cbss/7HCB2JAA"/> |
|
I have updated 5528.xml based on your feedback, and also added a first version of 5630.xml. Apologies that the pull request now contains two files — I'd expected it to create a separate one. A few points regarding 5630.xml:
Thanks for your feedback! |
2 participants
No description provided.