Jonah 07 02 2026 - #1392
Conversation
wlpotter
left a comment
wlpotter
left a comment
There was a problem hiding this comment.
@Jonah-Causin Great work! I've left some comments on several of the lines to give specific feedback and flag a few things for your review.
We can leave this pull request 'open'/unmerged, as I will want to make sure all of the information from your partner in the pair programming session also get included in the new record.
Feel free to reply to any of the comments should you need further clarification. Well done!
| </bibl> | ||
| </listBibl> | ||
|
|
||
| <listBibl type="editions"> |
There was a problem hiding this comment.
I don't know that this would throw a validation error, so this one is hard to catch. But we like to order the listBibl elements as follows: Editions, Manuscripts, Modern Translations, Ancient Versions, then Secondary Literature. Of course, not all records will have every type of bibl, so some listBibl elements will be left out. Still, we would want editions here to come before the other bibl types.
Do remember that in moving the bibls, you shouldn't change the @xml:id attributes (it is okay for them to be 'out of sequence').
wlpotter
left a comment
wlpotter
left a comment
There was a problem hiding this comment.
Thanks for sending updates to this file @Jonah-Causin! A few more small things to flag for you.
| <listBibl type="modernTranslations"> | ||
| <head>Modern Translations</head> | ||
| <desc xml:lang="en">This is not a comprehensive list of modern translations related to this work. Further citations may be available through <ref target="http://syriaca.org/cbss">The Comprehensive Bibliography on Syriac Studies</ref>.</desc> | ||
| <bibl xml:id="bib5525-1" type="syriaca:ModernTranslation"> |
There was a problem hiding this comment.
Ah, sorry I was not clear and misled you. It is fine to have bibl's whose xml:ids are out of sequence. What we want to avoid is changing those IDs after they have been created because we might be referring to them in other parts of the record. For example, if the abstract was sourced to this bibl (i.e., it had source="#bib5525-1"), when we change it to be bib5525-4, then we lose that footnote because the abstract is now pointing to a different bibl element.
| <bibl xml:id="work-5525" type="lawd:ConceptualWork"> | ||
| <title xml:id="name5525-1" xml:lang="en" srophe:tags="#syriaca-headword">Commentary on Luke</title> | ||
| <title xml:id="name5525-1" xml:lang="en" srophe:tags="#syriaca-headword" resp="http://syriaca.org">Commentary on Luke</title> | ||
| <author ref="http://syriaca.org/person/430" xml:lang="en"> — <foreign xml:lang="syr">ܩܘܪܝܠܠܘܣ ܕܐܠܟܣܢܕܪܝܐ</foreign> |
There was a problem hiding this comment.
One other thing I missed last time (and it was not in the Guidelines, so no worries for not catching it), is that we need either a source attribute or a resp on the author element. This might be a good place to point with a source attribute to one of the bibls, since they would no doubt assert that Cyril is the author of this commentary
Incomplete: Syriaca.org needs more URIs about this work to create a bibliography section
2 participants
Opening this PR to give feedback to workshop participants