Skip to content

Wall 07 02 2026 - #1400

Open
wlpotter wants to merge 9 commits into
2026-tei-workshop-basefrom
Wall_07_02_2026
Open

Wall 07 02 2026#1400
wlpotter wants to merge 9 commits into
2026-tei-workshop-basefrom
Wall_07_02_2026

Conversation

@wlpotter

@wlpotter wlpotter commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Created pull request to give feedback to workshop participants

@wlpotter wlpotter mentioned this pull request Jul 9, 2026

@wlpotter wlpotter left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @JustinMWall ! See the in-line comments for specific feedback. Let me know if I can clarify anything.

Comment thread data/works/tei/5506.xml Outdated
<text>
<body>
<bibl xml:id="work-5506" type="lawd:ConceptualWork">
<title xml:id="name5506-1" xml:lang="en" srophe:tags="#syriaca-headword">Homily on Edessa and Jerusalem</title>

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Work titles need either a source attribute pointing to a bibl xml:id (e.g., source="#bib5506-1") or a resp="http://syriaca.org" attribute

Comment thread data/works/tei/5506.xml Outdated
<bibl xml:id="work-5506" type="lawd:ConceptualWork">
<title xml:id="name5506-1" xml:lang="en" srophe:tags="#syriaca-headword">Homily on Edessa and Jerusalem</title>
<title xml:id="name5506-2" xml:lang="syr" srophe:tags="#syriaca-headword">ܡܐܡܪܐ ܕܥܠ ܐܘܪܗܝ ܘܥܠ ܐܘܪܫܠܡ</title>
<author ref="http://syriaca.org/person/42" xml:lang="en">Jacob of Serugh — <foreign xml:lang="syr">ܝܥܩܘܒ ܕܣܪܘܓ</foreign>

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

authors also need a source or resp

Comment thread data/works/tei/5506.xml
<listBibl type="editions">
<head>Editions</head>
<desc xml:lang="en">This is not a comprehensive list of editions related to this work. Further citations may be available through <ref target="http://syriaca.org/cbss">The Comprehensive Bibliography on Syriac Studies</ref>.</desc>
<bibl xml:id="bib5506-1" type="lawd:Edition" resp="http://syriaca.org">

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is fine, though not required, to have a resp on a listBibl/bibl

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Will! Can you provide further clarification on this? From NHSL 1.5.11.2. Editions (listBibl type="editions"), I understood that either a @source or @resp attribute is required:

"The following additional information should be encoded using attribute values within the [] or its descendants. NSHL records are required to cite their sources using either the @source or @resp attributes as described above. If the information about an edition is derived from another source (such as Zanetti and Detienne, Bibliotheca Hagiographica Syriaca) then that other source should be cited using @source. If the edition itself has been consulted directly by the Syriaca.org editor, then an @resp should be used with the value ‘http://syriaca.org’ to indicate that the editors of NSHL are responsible for the inclusion of the citation. (This practice avoids creating a circular citation back to the edition itself)."

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants