Skip to content

Saunders 07 02 2026 - #1401

Open
wlpotter wants to merge 5 commits into
2026-tei-workshop-basefrom
Saunders_07_02_2026
Open

Saunders 07 02 2026#1401
wlpotter wants to merge 5 commits into
2026-tei-workshop-basefrom
Saunders_07_02_2026

Conversation

@wlpotter

@wlpotter wlpotter commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Creating PR to give feedback to workshop participants

@wlpotter wlpotter mentioned this pull request Jul 9, 2026

@wlpotter wlpotter left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @zmjsaunders ! See the in-line comments for specific feedback. Let me know if I can clarify any of the below.

Comment thread data/works/tei/5505.xml Outdated
</langUsage>
</profileDesc>
<revisionDesc status="uncorrected-draft">
<change who="http://syriaca.org/documentation/editors.xml#dmichelson http://syriaca.org/documentation/editors.xml#dschwartz http://syriaca.org/documentation/editors.xml#wpotter" when="2026-06-24-05:00">CHANGED: Implemented revisions for the second edition, 2026.</change>

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to include the change element for you creating the file (the who attribute is your editors.xml URI, which you used in the editor and respStmt/name elements above, and the when attribute is the date you created the file)

Comment thread data/works/tei/5505.xml Outdated
<text>
<body>
<bibl xml:id="work-5505" type="lawd:ConceptualWork">
<title xml:id="name5505-1" xml:lang="en" srophe:tags="#syriaca-headword">Book of the Dove</title>

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Work titles need either a source attribute pointing to a bibl's xml:id (e.g., source="#bib5505-1") or a resp="http://syriaca.org" attribute

Comment thread data/works/tei/5505.xml Outdated
<body>
<bibl xml:id="work-5505" type="lawd:ConceptualWork">
<title xml:id="name5505-1" xml:lang="en" srophe:tags="#syriaca-headword">Book of the Dove</title>
<author ref="https://syriaca.org/person/239" xml:lang="en">Gregory Bar Hebraeus<foreign xml:lang="syr">ܓܪܝܓܘܪܝܘܣܒܪ ܥܒܪܝܐ</foreign>

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

author elements also need a source or resp attribute, like in titles.

Also, careful with "https" vs "http", Syriaca URIs should use "http"

Comment thread data/works/tei/5505.xml Outdated
</author>
<idno type="URI">http://syriaca.org/work/5505</idno>
<textLang mainLang="syr"/>
<date>13th cent. CE</date>

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! You can include as well the notBefore and notAfter attributes to give the standardized date range, e.g. "1200" and "1300"

Comment thread data/works/tei/5505.xml Outdated
</bibl>
<!-- Replace this note with additional bibl elements as needed. -->
</listBibl>
<listBibl type="secondaryLiterature">

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you have multiple bibls that are "secondary literature"/"citation", put them both in the listBibl of @type="secondaryLiterature" rather than creating a second listBibl. Think of the listBibl as a container grouping similar kinds of bibliography, or even different sections of a large bibliography.

Here, for instance, you'd put bib5505-2 below line 123, and can delete this second listBibl

Comment thread data/works/tei/5505.xml Outdated
<desc xml:lang="en">This is not a comprehensive list of secondary literature related to this work. Further citations may be available through <ref target="http://syriaca.org/cbss">The Comprehensive Bibliography on Syriac Studies</ref>.</desc>
<bibl xml:id="bib5505-1" type="lawd:Citation">
<title xml:lang="en">Christian Spiritual Sources in Barhebraeus’ Ethicon and the Book of the Dove</title>
<ptr target="https://syriaca.org/cbss/4ARYCKV2"/>

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

flagging the https -> http

Comment thread data/works/tei/5505.xml Outdated
<desc xml:lang="en">This is not a comprehensive list of secondary literature related to this work. Further citations may be available through <ref target="http://syriaca.org/cbss">The Comprehensive Bibliography on Syriac Studies</ref>.</desc>
<bibl xml:id="bib5505-2" type="lawd:Citation">
<title xml:lang="en">Book of the Dove: Ascetic Instructions by Gregory Bar Hebraeus</title>
<ptr target="https://syriaca.org/cbss/6BWM53YZ"/>

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https -> http

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants