Skip to content

Pragt 07 02 2026 - #1409

Open
MPragt wants to merge 3 commits into
2026-tei-workshop-basefrom
pragt_07_02_2026
Open

Pragt 07 02 2026#1409
MPragt wants to merge 3 commits into
2026-tei-workshop-basefrom
pragt_07_02_2026

Conversation

@MPragt

@MPragt MPragt commented Jul 9, 2026

Copy link
Copy Markdown

Trial to create the pull request for 5525.xml (Cyril of Alexandria's Commentary on Luke)

@wlpotter
wlpotter changed the base branch from master to 2026-tei-workshop-base July 9, 2026 16:03

@wlpotter wlpotter left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @MPragt ! I've left in-line comments with feedback; please let me know if I can clarify anything

Comment thread data/works/tei/5525.xml
<text>
<body>
<bibl xml:id="work-5525" type="lawd:ConceptualWork">
<title xml:id="name5525-1" xml:lang="en" srophe:tags="#syriaca-headword"> </title>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Work titles should have a source attribute (e.g., source="#bib5525-1") or a resp="http://syriaca.org" if they don't have a citationi

Comment thread data/works/tei/5525.xml
<body>
<bibl xml:id="work-5525" type="lawd:ConceptualWork">
<title xml:id="name5525-1" xml:lang="en" srophe:tags="#syriaca-headword"> </title>
<author ref="http://syriaca.org/person/430" xml:lang="en"> — <foreign xml:lang="syr">ܩܘܪܝܠܠܘܣ ܕܐܠܟܣܢܕܪܝܐ</foreign>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Authors should also have a source or resp

Comment thread data/works/tei/5525.xml
<listBibl type="editions">
<head>Editions</head>
<desc xml:lang="en">This is not a comprehensive list of editions related to this work. Further citations may be available through <ref target="http://syriaca.org/cbss">The Comprehensive Bibliography on Syriac Studies</ref>.</desc>
<bibl source="#bib5525-1" xml:id="bib5525-1" type="lawd:Edition">

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is fine to include a source for bibls, e.g. if we know that a manuscript is a witness to a work because of a printed catalogue, we could source the manuscript's bibl to the catalogue's bibl. However, here we wouldn't want to source a bibl to itself. You can, optionally, add a resp but that is not required

Comment thread data/works/tei/5525.xml
</bibl>
<bibl xml:id="bib5525-2" type="lawd:Edition">
<title xml:lang="en">Fragments of the Homilies of Cyril of Alexandria on the Gospel of S. Luke</title>
<ptr target="https://syriaca.org/cbss/YM8BE8C5"/>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Careful of "https" vs "http", Syriaca URIs should be 'http'

Comment thread data/works/tei/5525.xml
<listBibl type="manuscripts">
<head>Manuscripts</head>
<desc xml:lang="en">This is not a comprehensive list of manuscripts related to this work.</desc>
<bibl xml:id="bib5525-4" source="bib5525-1" type="syriaca:Manuscript">

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Source attributes should start with the "#" to indicate they are pointing to another identifier

Comment thread data/works/tei/5525.xml
<head>Manuscripts</head>
<desc xml:lang="en">This is not a comprehensive list of manuscripts related to this work.</desc>
<bibl xml:id="bib5525-4" source="bib5525-1" type="syriaca:Manuscript">
<label>London, British Library<idno type="shelfmark">Add. 14552</idno>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We would want to leave a space between "Library" and the start of the idno element

Comment thread data/works/tei/5525.xml
<listBibl type="modernTranslations">
<head>Modern Translations</head>
<desc xml:lang="en">This is not a comprehensive list of modern translations related to this work. Further citations may be available through <ref target="http://syriaca.org/cbss">The Comprehensive Bibliography on Syriac Studies</ref>.</desc>
<bibl xml:id="bib5525-5" source="bib5525-1" type="syriaca:ModernTranslation">

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As above, source should start with "#" here

Comment thread data/works/tei/5525.xml
<listBibl type="modernTranslations">
<head>Modern Translations</head>
<desc xml:lang="en">This is not a comprehensive list of modern translations related to this work. Further citations may be available through <ref target="http://syriaca.org/cbss">The Comprehensive Bibliography on Syriac Studies</ref>.</desc>
<bibl xml:id="bib5525-6" source="bib5525-1" type="syriaca:ModernTranslation">

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also here, source should start with "#"

Comment thread data/works/tei/5525.xml
<head>Ancient Versions</head>
<desc xml:lang="en">This is not a comprehensive list of ancient versions related to this work.</desc>
<bibl xml:id="bib5525-8" source="bib5525-1" type="syriaca:AncientVersion">
<title xml:lang="grc"></title>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget the text node of the title

Comment thread data/works/tei/5525.xml
<head>Secondary Literature</head>
<desc xml:lang="en">This is not a comprehensive list of secondary literature related to this work. Further citations may be available through <ref target="http://syriaca.org/cbss">The Comprehensive Bibliography on Syriac Studies</ref>.</desc>
<bibl xml:id="bib5525-7" type="lawd:Citation">
<title xml:lang="en"> </title>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget the text node of the title

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants