Ji 07 08 2026 - #1410
Conversation
wlpotter
left a comment
wlpotter
left a comment
There was a problem hiding this comment.
Great work @Xiaoyan-Ji-Syr ! I've left some in-line comments, though I know you are actively working on this so maybe those comments have already been fixed...Let me know if I can clarify any of my notes.
| <text> | ||
| <body> | ||
| <bibl xml:id="work-5505" type="lawd:ConceptualWork"> | ||
| <title xml:id="name5505-1" xml:lang="en" srophe:tags="#syriaca-headword">Book of the Dove</title>source="#bib5505-1" |
There was a problem hiding this comment.
Make sure the source is an attribute on title, looks like it is in the text node after it instead
| <body> | ||
| <bibl xml:id="work-5505" type="lawd:ConceptualWork"> | ||
| <title xml:id="name5505-1" xml:lang="en" srophe:tags="#syriaca-headword">Book of the Dove</title>source="#bib5505-1" | ||
| <author ref="https://syriaca.org/person/239" xml:lang="en"> Bar Hebraeus— <foreign xml:lang="syr">ܓܪܝܓܘܪܝܘܣܒܪ ܥܒܪܝܐ<!-- Add Syriac name if known or delete hyphen, space, and foreign element --></foreign> |
There was a problem hiding this comment.
authors also need either a source or resp attribute
| <title xml:id="name5505-1" xml:lang="en" srophe:tags="#syriaca-headword">Book of the Dove</title>source="#bib5505-1" | ||
| <author ref="https://syriaca.org/person/239" xml:lang="en"> Bar Hebraeus— <foreign xml:lang="syr">ܓܪܝܓܘܪܝܘܣܒܪ ܥܒܪܝܐ<!-- Add Syriac name if known or delete hyphen, space, and foreign element --></foreign> | ||
| </author> | ||
| <date>1226-1286 CE</date>source="#bib5505-2" |
There was a problem hiding this comment.
source should be an attribute, i.e. before the > of the date element's opening tag
| </author> | ||
| <date>1226-1286 CE</date>source="#bib5505-2" | ||
| <!-- You can add an editor element here or replace the author with editor if appropriate. --> | ||
| <idno type="URI">http://syriaca.org/work/5505/tei</idno> |
There was a problem hiding this comment.
The idno in the body/bibl element should be for the conceptual work, so shouldn't have the /tei in it. Remember, the teiHeader is for the XML document, whose identifier/URI is .../tei, but the body is for the conceptual entity
| <!-- You can add an optional date element or delete this note. --> | ||
| <noteGrp type="abstract"> | ||
| <desc xml:lang="en">Abstract</desc> | ||
| <note corresp="http://syriaca.org/nhsl" xml:id="abstract-en-5505" xml:lang="en" type="abstract" resp="http://syriaca.org">AThe Book of the Dove is the ascetical guide composed by Bar-Hebraeus for aspiring hermits. It concerns the training of the body and the soul for ascetical life.</note> |
There was a problem hiding this comment.
There is a typo where the abstract (note element) starts with "AThe", I assume it should be "The"?
| <desc xml:lang="en">This is not a comprehensive list of modern translations related to this work. Further citations may be available through <ref target="http://syriaca.org/cbss">The Comprehensive Bibliography on Syriac Studies</ref>.</desc> | ||
| <bibl xml:id="bib5505-1" type="syriaca:ModernTranslation"> | ||
| <title xml:lang="en">Bar Hebraeus’s Book of the Dove, together with Some Chapters from his Ethikon </title> | ||
| <ptr target="https://syriaca.org/cbss/2CMS7CFD"/> |
There was a problem hiding this comment.
Careful of "https" vs "http", Syriaca URIs should be "http"
| <bibl xml:id="bib9530-1" type="editions"> | ||
| <title xml:lang="en"></title> | ||
| <ptr target="http://syriaca.org/cbss/4ZJXAJI3"/> | ||
| <citedRange unit=""></citedRange> |
There was a problem hiding this comment.
The cited range can be deleted if citing the full bibliographic item
| <ptr target="http://syriaca.org/cbss/4ZJXAJI3"/> | ||
| <citedRange unit=""></citedRange> | ||
| <listRelation> | ||
| <relation active="" ref="dcterms:source" passive=""> |
There was a problem hiding this comment.
I think we probably want to delete this relation? Maybe the title on line 115 should go up in line 109?
2 participants
Pull request for giving feedback to workshop participants