Merged
Conversation
Reviewer's GuideSwitches Stake NYSE and ASX API base URLs to the new api2 host and consistently prefixes endpoints with the /api path segment, while also normalizing watchlist URLs to be built from the common base URL and adding a dedicated update_watchlist URL. Class diagram for updated NYSEUrl and ASXUrl API endpointsclassDiagram
class NYSEUrl {
<<BaseModel>>
STAKE_URL : str = https://api2.prd.hellostake.com/
account_balance : str
account_transactions : str
brokerage : str
cancel_order : str
cash_available : str
create_session : str
equity_positions : str
fund_details : str
market_status : str
orders : str
products_suggestions : str
quick_buy : str
quotes : str
rate : str
ratings : str
sell_orders : str
symbol : str
transaction_history : str
transaction_details : str
transactions : str
users : str
watchlists : str
create_watchlist : str
read_watchlist : str
update_watchlist : str
statement : str
}
class ASXUrl {
<<BaseModel>>
ASX_STAKE_URL : str = https://api2.prd.hellostake.com/api/asx/
brokerage : str
}
NYSEUrl <|-- ASXUrl : shares BaseModel
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The watchlist endpoints were previously using the separate
api.prd.stakeover.iohost and are now derived fromSTAKE_URL; if those services are still hosted separately, consider keeping a dedicated base URL constant for watchlists instead of reusingSTAKE_URL. - For consistency and easier future changes, consider aligning the ASX base URL pattern with the NYSE one (e.g., moving
/api/out ofASX_STAKE_URLand into the individual paths, or vice versa) so both markets follow the same structure.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The watchlist endpoints were previously using the separate `api.prd.stakeover.io` host and are now derived from `STAKE_URL`; if those services are still hosted separately, consider keeping a dedicated base URL constant for watchlists instead of reusing `STAKE_URL`.
- For consistency and easier future changes, consider aligning the ASX base URL pattern with the NYSE one (e.g., moving `/api/` out of `ASX_STAKE_URL` and into the individual paths, or vice versa) so both markets follow the same structure.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
updates urls to
api2endpointsSummary by Sourcery
Update Stake API base URLs to use the new api2 host and align endpoint paths across NYSE and ASX services.
Enhancements: