fix: fix dataraces in testlog and snap sync test (ethereum#29301) - #112
Merged
Merged
Conversation
(cherry picked from commit 04bf1c802ffe9dfc34c34b3e666ee15e96b4a203)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Backports ethereum/go-ethereum#29301, which fixes two data races reported by
go test -race ./....Upstream References
Changes
internal/testlog/testlog.go: add async.MutextobufHandlerand guardHandle,WithAttrs, andflushso that concurrent access to the shared record buffer is serialized.eth/protocols/snap/sync_test.go: removet.Parallel()fromTestSyncAccountPerformancebecause it mutates the global varaccountConcurrency.