fix: reject block with nil GasTip in verifyGasTip - #113
Merged
Merged
Conversation
Treat nil extra.GasTip as a mismatch error to resolve the bypass where nil was silently accepted instead of being validated against the governance contract value.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
The GasTip validation condition in block header verification was fixed to treat
nilas a mismatch against the governance contract value instead of accepting it as valid.Problem
A
nilGasTip was never validated against the governance contract value because the condition only compared when the value was non-nil.Solution
Treat
nilGasTip as a mismatch against the governance contract value, so validation fails regardless of whether the value is absent or incorrect.Since the WBFT engine is only active when Anzeon is enabled, and a valid Anzeon configuration always provides a defined GasTip, a
nilGasTip is an invalid state and must be rejected.Changes
consensus/wbft/engine/engine.go: update condition inverifyGasTipextra.GasTip != nil && extra.GasTip.Cmp(gastip) != 0extra.GasTip == nil || extra.GasTip.Cmp(gastip) != 0