fix: pre-allocate AccessList slice in SetSenderTx before copying - #115
Merged
Merged
Conversation
Pre-allocate AccessList with make before copying to fix missing memory allocation in zero-initialized SenderTx, which caused all entries to be lost and sender signature recovery to fail.
Add a test reproducing the RPC assembly path to verify that AccessList is preserved through SetSenderTx and that sender/feePayer signatures can be recovered correctly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Fix a bug where the AccessList in a fee-delegated transaction is lost during RPC assembly, causing signature recovery to fail.
Problem
When copying the AccessList via
copy, the destination slice was zero-initialized with no allocated memory, causing all entries to be silently lost and subsequent signature recovery to fail.Solution
Pre-allocate memory for the destination AccessList slice before copying to prevent data loss.
Changes
core/types/tx_fee_delegation.go: pre-allocateAccessListslice withmakebeforecopyinSetSenderTx