fix: avoid setting db.cleans to nil on Close (ethereum#29309) - #118
Merged
Merged
Conversation
(cherry picked from commit f46fe62c5d1d25ce0e9869ecbaf0e5722d2bc2f5)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove the
db.cleans = nilassignment inClose()to prevent a potential data race with concurrentnode()orcommit()calls that accessdb.cleanswithout a lock.Upstream References
Problem
db.cleansis accessed without a lock innode()(L189, L214) andcommit()(L532), whileClose()sets it tonilalso without a lock. A concurrent goroutine that passes thedb.cleans != nilcheck and then callsdb.cleans.Get/SetafterClose()nullifies the pointer will panic.Changes
triedb/hashdb/database.go: Removedb.cleans = nilinClose().db.cleans.Reset()already clears the cache contents; thecleansfield is collected by GC along with its ownerdb, so the nil assignment serves no purpose.