fix: check storage root existence for hash scheme too (ethereum#29341) - #121
Merged
Merged
Conversation
…341) (cherry picked from commit 304879da20200f6912d241ccd471e140d3487093)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ports ethereum#29341. The storage root existence check in
processStorageResponseonly worked under path scheme, causing state healing to run unnecessarily on hash-scheme nodes.Upstream References
Problem
PR #28327 added a check to confirm the storage root node is present in the database before skipping state healing. However, the check used
rawdb.HasStorageTrieNode, which only reads nodes under path scheme. On hash-scheme nodes the function always returnsfalse, so the healing-skip optimization never fires.Changes
eth/protocols/snap/sync.go: replacerawdb.HasStorageTrieNode(s.db, accountHash, nil, root)withrawdb.HasTrieNode(s.db, accountHash, nil, root, s.scheme), making the check work for both path and hash scheme