fix: use syscall-derived max IPC path size per OS (ethereum#29385) - #122
Merged
Merged
Conversation
(cherry picked from commit e63f992fed51d5a576ea2890cd7eb3000c9e6884)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ports ethereum#29385.
maxPathSizewas hardcoded to 108 (Linux value), causing IPC bind failures on Darwin where the unix socket path limit is 104 bytes. Replace the constant withlen(syscall.RawSockaddrUnix{}.Path)so the correct OS-specific limit is used at compile time.Upstream References
Problem
On Darwin,
syscall.RawSockaddrUnix.Pathis 104 bytes, but geth assumed 108. A datadir path between 104–107 bytes would pass the length check yet fail atbind, producing aninvalid argumenterror and preventing the node from starting.Changes
rpc/ipc_unix.go: replace hardcodedmaxPathSize = 108withmaxPathSize = len(syscall.RawSockaddrUnix{}.Path), picking up the OS-specific limit at compile time