fix: reopen statedb for dump after commit (ethereum#29437) - #123
Merged
Merged
Conversation
(cherry picked from commit fe0bf325a68504292f910240f8da6243defffa71)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ports ethereum#29437. After
statedb.Commit()the trie is marked as committed and can no longer be traversed, causingstatedb.Dump()to fail with "trie is already committed" and return an empty result. Open a fresh statedb from the committed root before dumping.Upstream References
Problem
evm --dump runcalledstatedb.Dump()on the same instance afterstatedb.Commit(). The committed trie cannot be traversed again, so dumping silently fails and returnsaccounts: {}.Changes
cmd/evm/runner.go: capture root fromstatedb.Commit(), open a newstate.New(root, sdb, nil), and callDump()on the new instance