fix: convert legacy log level in debug_verbosity (ethereum#29356) - #124
Merged
Merged
Conversation
…9356) (cherry picked from commit 9cb8de87037be7c38343b2f84c534887e7525c5d)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ports ethereum#29356.
debug_verbositywas casting the legacy level integer directly toslog.Levelinstead of converting it. Since legacy levels (0=Crit, 5=Trace) and slog levels (Crit=12, Trace=-8) run in opposite directions, callingdebug_verbosity(0)set Info instead of Crit.Upstream References
debug_verbosityProblem
slog.Level(level)treats the raw integer as a slog level value directly. Legacy level 0 maps toslog.Level(0)which is Info, not Crit. Thelog.FromLegacyLevelhelper already exists in the codebase for exactly this conversion.Changes
internal/debug/api.go: replaceglogger.Verbosity(slog.Level(level))withglogger.Verbosity(log.FromLegacyLevel(level))