fix: close clients in tests (ethereum#29512) - #128
Merged
Merged
Conversation
(cherry picked from commit 71c78bf56da29dc8b85cddc9da09eabf18131ee8)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ports ethereum#29512. Add missing
defer client.Close()/defer c.Close()calls in RPC tests to prevent goroutine leaks after test execution, and remove a duplicatedefer client.Close()inTestClientHTTP.Upstream References
Changes
rpc/client_test.go: adddefer client.Close()inTestClientBatchRequestLimit,testClientCancel,TestClientSubscriptionChannelClose; remove duplicatedefer client.Close()inTestClientHTTPrpc/websocket_test.go: adddefer c.Close()inTestWebsocketPeerInfo,TestClientWebsocketLargeMessage