feat(cli): add browser permission settings commands#1436
Open
Nikolatesla-lj wants to merge 3 commits intostablyai:mainfrom
Open
feat(cli): add browser permission settings commands#1436Nikolatesla-lj wants to merge 3 commits intostablyai:mainfrom
Nikolatesla-lj wants to merge 3 commits intostablyai:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Depends on
This branch is stacked on top of the browser permission system in #1435. Review after that PR or compare commit-by-commit.
What changed
orca settings get --key browserInteractionMode|browserPermissionNoticePolicyorca settings set --key ... --value ...orca browser-permissions listorca browser-permissions allow --origin <origin> --permission <name>orca browser-permissions deny --origin <origin> --permission <name>orca browser-permissions prompt --origin <origin> --permission <name>orca browser-permissions remove --origin <origin> --permission <name>Why
The browser permission system should live in the main application, not the CLI. This PR keeps that boundary intact: the CLI only reads and updates the settings and remembered site rules that the first PR introduced.
Tests
./node_modules/.bin/vitest run src/cli/settings-browser-permissions.test.ts src/cli/index.test.ts./node_modules/.bin/tsc --noEmit -p config/tsconfig.node.json --composite false./node_modules/.bin/tsc --noEmit -p config/tsconfig.cli.json --composite false