fix: enable Codex hook notifications#1441
Open
AmoabaKelvin wants to merge 1 commit intostablyai:mainfrom
Open
Conversation
Install Codex hooks during startup even when the agent dashboard experiment is disabled, while keeping Claude and Gemini behind the experiment flag. Route Codex hook completion events through the existing terminal notification dispatcher so notification settings, labels, and sounds stay consistent with title-based completions. Validation: pnpm test -- src/main/agent-hooks/startup-hook-installation.test.ts src/renderer/src/hooks/useIpcEvents.test.ts src/renderer/src/components/terminal-pane/pty-connection.test.ts; pnpm typecheck:web; pnpm typecheck:node; pnpm exec oxfmt --check touched files.
AmethystLiang
requested review from
Jinwoo-H and
brennanb2025
and removed request for
Jinwoo-H
Contributor
|
Will check this one out tomorrow. Thanks for all the PRs @AmoabaKelvin , I always appreciate seeing one from you! |
Contributor
|
okay @brennanb2025 is going to get this in tomorrow, we chatted about it 🫡 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Install Codex hooks during startup even when the agent dashboard experiment is disabled, while keeping Claude and Gemini behind the experiment flag.
Route Codex hook completion events through the existing terminal notification dispatcher so notification settings, labels, and sounds stay consistent with title-based completions.
Validation:
pnpm test -- src/main/agent-hooks/startup-hook-installation.test.ts src/renderer/src/hooks/useIpcEvents.test.ts src/renderer/src/components/terminal-pane/pty-connection.test.tspnpm lintpnpm typecheckpnpm testpnpm build