Skip to content

fix: avoid repeated macOS privacy prompts#1524

Merged
nwparker merged 7 commits intomainfrom
nwparker/https-github.com-stablyai-orca-issues-1522
May 7, 2026
Merged

fix: avoid repeated macOS privacy prompts#1524
nwparker merged 7 commits intomainfrom
nwparker/https-github.com-stablyai-orca-issues-1522

Conversation

@nwparker
Copy link
Copy Markdown
Contributor

@nwparker nwparker commented May 7, 2026

Fixes #1522.

Summary

  • Stop eager/global authorized-root rebuilds from startup, repo mutations, and worktree list refreshes.
  • Seed filesystem auth roots from already-returned worktree list results, and avoid realpath() until a specific file operation needs canonicalization.
  • Remove the right-sidebar branch-change fetchWorktrees poll by returning branch/head from git status --branch for local and SSH paths.
  • Avoid background repo/worktree enumeration in terminal-history GC and optional Claude/Codex usage analytics.
  • Keep SSH repos out of local filesystem authorization and usage attribution roots.
  • Resolve the main merge’s oxlint 1.63 fallout by dropping the removed react/jsx-uses-vars rule and replacing one existing error-boundary componentDidUpdate reset with derived state.

Verification

  • pnpm exec vitest run --config config/vitest.config.ts src/main/ipc/filesystem.test.ts src/main/ipc/worktrees.test.ts src/main/ipc/worktrees-windows.test.ts src/main/ipc/repos-create.test.ts src/main/ipc/repos-sparse-presets.test.ts src/main/ipc/repos-remote.test.ts src/main/git/status.test.ts src/relay/git-handler.test.ts src/renderer/src/store/slices/worktrees.test.ts src/main/window/attach-main-window-services.test.ts src/main/window/history-gc-worktree-ids.test.ts src/main/terminal-history.test.ts src/main/usage-worktree-metadata.test.ts src/main/claude-usage/store.test.ts src/main/codex-usage/store.test.ts src/main/claude-usage/scanner.test.ts src/main/codex-usage/scanner.test.ts
  • pnpm exec oxlint --format github
  • pnpm exec oxlint <touched files>
  • pnpm run tc:node
  • pnpm run tc:web
  • Final permission-dialog scan over worktree listing, renderer polling, and filesystem probe callsites.

Copy link
Copy Markdown
Contributor Author

@nwparker nwparker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed locally. No blocking findings. I specifically re-checked the root cause path for #1522, the new seeded auth-root cache behavior, local-vs-SSH path boundaries, the branch/head status polling replacement, terminal-history GC, and optional usage analytics. Focused Vitest coverage, oxlint, tc:node, and tc:web all pass locally.

@nwparker nwparker closed this May 7, 2026
@nwparker nwparker deleted the nwparker/https-github.com-stablyai-orca-issues-1522 branch May 7, 2026 06:24
@nwparker nwparker reopened this May 7, 2026
@nwparker nwparker merged commit 7b83b2d into main May 7, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Repeated asking for folder permissions for no apparent reason

1 participant