Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an experimental Asahi kernel leaves
boot.binmissing whileboot.bin.oldorboot.bin.omarchy-pre-wipremains,omarchy-mac-kernel-wip --rollback-bootcannot discover the ESP path and refuses to restore the saved image. The installer also continued after failing to create its recovery snapshot.This follow-up makes the recovery path functional for that state:
boot.binpath from either saved image;The regression test uses the real helper functions and a disposable ESP-shaped directory. Against PR343 baseline
ea3267b, the saved-image-only rollback case fails. Atc22ff171a7be257fbda7d2176d322a52bbb4af7b, it restores successfully; the test also covers stale restore directories, failed copy/rename cleanup, package-install refusal on snapshot failure, and the existing rollback/remove cases.Validation:
bash test/shell.d/apple-kernel-wip-test.sh,bash -non the command and test, andgit diff --checkpass. This was validated with scratch files on macOS/APFS. No native Linux ESP, package-manager transaction, reboot, firmware update, or physical M3 boot was performed, so those runtime paths remain for maintainer validation.This change was AI-assisted and independently QA-tested and reviewed. Related M3 integration context: omacom#343