Skip to content

Conversation

@sbernauer
Copy link
Member

Description

As part of the bump we had to switch from chrono to jiff for the parts where we interact with kube.
For consistency reasons I also switched over the EOS checker, so we now only depend on jiff.

However, we are now running into kube-derive schema problems again. While kube 3.0.0 has fixed two bugs, there are still two or so remaining, that where previously fixed by our fork in https://github.com/stackabletech/kube-rs/tree/2.0.1-fix-schema-hoisting.
We need to fix the two bugs before we can merge this.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants