fix: octavia-api broken in multinode OVS #2051
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When kolla_enable_ovn is false, fallback to amphora driver
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request correctly makes the octavia_provider_drivers conditional based on whether OVN is enabled, which is a good fix for non-OVN deployments. However, the change is incomplete as it does not update the related octavia_provider_agents configuration. This will likely cause issues when OVN is disabled. I have added a comment to highlight this and suggest a fix to ensure the Octavia configuration remains consistent.
Contributor
Author
|
I don't know a correct value for the agent for amphora. |
Member
My general strategy with things like that is to just grep through the source of kolla ansible/kayobe etc for the variable to see if I can find it defined anywhere already |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When kolla_enable_ovn is false, fallback to amphora driver