DNM - test pulp collections bump #2054
Draft
+18
−67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the pulp.squeezer and stackhpc.pulp Ansible collections and refactors the artifact upload playbook to use new features, which simplifies the logic. While the simplification is a good improvement, there are a few issues to address. The stackhpc.pulp collection is pinned to a git branch, which is not ideal for reproducible builds. Additionally, a test comment has been left in a configuration file, and the retry delay for artifact uploads has been significantly reduced, which might need reconsideration. The PR title indicates this is a test, but these points are important for when this change is intended for merging.
Alex-Welsh
force-pushed
the
test-squeezer-bump
branch
from
a74d6fc to
eb61174
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.