Leverage Google Cloud Task deduplication mechanism#163
Open
jfradj wants to merge 1 commit intostackkit:masterfrom
Open
Leverage Google Cloud Task deduplication mechanism#163jfradj wants to merge 1 commit intostackkit:masterfrom
jfradj wants to merge 1 commit intostackkit:masterfrom
Conversation
…Google Cloud Task deduplication mechanism
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows a job to define a cloud task id and thus leverage the powerful Google Cloud Task deduplication mechanism.
Indeed Google provide a guarantee deduplication mechanism
Right now, the task id (i.e. task name) is build using a ULID, so each submitted job will have its own unique id.
Which is great most of the time.
But doing so totally prevents the use of the deduplication feature.
With this PR, any Job defining a class property
public string $cloudTaskId;will be able to have control on the submitted task id and be able to rely on the deduplication feature.