Merged
Conversation
Thanks clippy
We don't need more, and what we had before was utterly confusing.
This is incomplete. Currently we only support fetching pre-build tree-sitter-cli. I'd like to add building from source too.
And the code is far easier to read now.
My PR fixed the flakiness issue, so it's time to be strict tree-sitter/tree-sitter#5174
stackmystack
force-pushed
the
overhaul-errors
branch
from
690737a to
ed72f47
Compare
stackmystack
force-pushed
the
overhaul-errors
branch
7 times, most recently
from
0279b04 to
51a2d66
Compare
stackmystack
force-pushed
the
overhaul-errors
branch
11 times, most recently
from
478b157 to
8729128
Compare
stackmystack
force-pushed
the
overhaul-errors
branch
from
8729128 to
1360d34
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a heavy rewrite of the internals of tsdl. I worked on it over a long-ish period of time.
There's a lot to be desired still … but here's the most notable changes:
Everything else is mostly cleanup or noise.