Skip to content

Change the conditions the train settings button appears under. #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stacode123 merged 2 commits into from
Mar 12, 2026
Merged

Change the conditions the train settings button appears under. #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6f4d3c6
Add the texture file that was missing from the repo
K2568 Mar 11, 2026
7b324ae
Change settings button requirements
K2568 Mar 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion common/src/main/java/net/Realism/mixin/client/StationScreenMixin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ public StationScreenMixin(StationBlockEntity be, GlobalStation station) {

@Unique
private void alignAndToggleSettings() {
realism$settingsButton.visible = this.disassembleTrainButton.visible && this.disassembleTrainButton.active;
realism$settingsButton.visible = this.disassembleTrainButton.visible;
Copy link

Copilot AI Mar 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR description says this change enables trains to be disassembled in additional situations, but this line only changes when the settings button is shown (it no longer depends on disassembleTrainButton.active). If the intent is purely UI/UX (show settings even when disassemble is disabled), consider updating the PR description accordingly; if the intent is to change disassembly rules, that logic likely lives elsewhere and won’t be affected by this change.

Copilot uses AI. Check for mistakes.
Copy link
Contributor Author

@K2568 K2568 Mar 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ignore this, i accidentally put disassemble instead of edit settings.

}
@Unique
private void onSettingsPressed() {
Expand Down
Binary file added common/src/main/resources/assets/realism/textures/gui/settings.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading