feat(site): convert description prop on PageSection to named slot - #55
Merged
suejinkim20 merged 3 commits intoAug 26, 2026
Merged
Conversation
suejinkim20
force-pushed
the
feature/page-section-description-slot
branch
2 times, most recently
from
August 25, 2026 20:47
94f4eb1 to
d415821
Compare
suejinkim20
force-pushed
the
feature/page-section-description-slot
branch
from
August 25, 2026 20:49
d415821 to
4d97812
Compare
suejinkim20
changed the title
mbwatson
approved these changes
Aug 26, 2026
mbwatson
left a comment
mbwatson
left a comment
Member
There was a problem hiding this comment.
looks good!
because PageSection will now use a named description slot, let's update the packages/ui-astro/README.md note about receiving "all content via props" to mention props + slots; something like:
Components are presentational and receive content through typed props plus default/named slots for richer markup.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR converts the "description" prop on the PageSection component to a named slot.