Skip to content

fix: add shell: bash to tag verification steps for Windows runner#12

Merged
Philippoes merged 1 commit intomainfrom
fix/release-windows-shell
Mar 3, 2026
Merged

fix: add shell: bash to tag verification steps for Windows runner#12
Philippoes merged 1 commit intomainfrom
fix/release-windows-shell

Conversation

@ajag408
Copy link
Contributor

@ajag408 ajag408 commented Mar 2, 2026

Summary by CodeRabbit

Release Notes

This is a patch release (v1.2.2) with no user-facing changes. Internal release workflow improvements have been made to support consistent deployment processes.

The v1.2.1 release failed on the win32-x64 binary build because the "Verify tag is on main" step uses bash syntax (if !), but Windows runners default to PowerShell.

The security-audit and publish jobs weren't affected since they run on ubuntu-latest where bash is already the default shell. Only the build-binaries job hits this because the win32-x64 matrix entry runs on windows-latest.

Changes

  • Add shell: bash to the "Verify tag is on main" step in the publish job (for consistency)
  • Add shell: bash to the "Verify tag is on main" step in the build-binaries job (fixes the failure)

Test plan

  • After merge, tag v1.2.2 and confirm all 4 platform builds pass (linux-x64, darwin-arm64, darwin-x64, win32-x64)

@coderabbitai
Copy link

coderabbitai bot commented Mar 2, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 37813c8 and 922805a.

📒 Files selected for processing (2)
  • .github/workflows/release.yml
  • package.json

📝 Walkthrough

Walkthrough

Two straightforward changes to the repository: explicit bash shell specification added to three verification steps in the release workflow, and a patch version bump in package.json from 1.2.1 to 1.2.2.

Changes

Cohort / File(s) Summary
Workflow Configuration
.github/workflows/release.yml
Added explicit bash shell specification to three "Verify tag is on main" steps, maintaining existing functionality with explicit invocation context.
Version Update
package.json
Patch version bump from 1.2.1 to 1.2.2.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested reviewers

  • jdomingos
  • raiseerco
  • Philippoes
  • petar-omni

Poem

🐰 A bash shell declared with care,
Version bumped, we're almost there,
Workflow steps now crystal clear,
1.2.2 brings cheer! 🎉

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: adding explicit bash shell specification to tag verification steps for Windows runner compatibility.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/release-windows-shell

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.


Comment @coderabbitai help to get the list of available commands and usage tips.

@Philippoes Philippoes merged commit 529a5d5 into main Mar 3, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants