fix: add shell: bash to tag verification steps for Windows runner#12
fix: add shell: bash to tag verification steps for Windows runner#12Philippoes merged 1 commit intomainfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: Organization UI Review profile: CHILL Plan: Pro Disabled knowledge base sources:
📒 Files selected for processing (2)
📝 WalkthroughWalkthroughTwo straightforward changes to the repository: explicit bash shell specification added to three verification steps in the release workflow, and a patch version bump in package.json from 1.2.1 to 1.2.2. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Comment |
Summary by CodeRabbit
Release Notes
This is a patch release (v1.2.2) with no user-facing changes. Internal release workflow improvements have been made to support consistent deployment processes.
The
v1.2.1release failed on thewin32-x64binary build because the "Verify tag is on main" step uses bash syntax (if !), but Windows runners default to PowerShell.The
security-auditandpublishjobs weren't affected since they run onubuntu-latestwhere bash is already the default shell. Only thebuild-binariesjob hits this because thewin32-x64matrix entry runs onwindows-latest.Changes
shell: bashto the "Verify tag is on main" step in thepublishjob (for consistency)shell: bashto the "Verify tag is on main" step in thebuild-binariesjob (fixes the failure)Test plan
v1.2.2and confirm all 4 platform builds pass (linux-x64, darwin-arm64, darwin-x64, win32-x64)