Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The MIME boundary scanners treat any
--<boundary>sequence as a delimiter, even when it appears in the middle of a line or is only a prefix of a longer token. This can silently truncate a MIME part without settingis_encoding_problem.For example, with boundary
BND:was parsed as:
The same issue affects the Base64 and quoted-printable MIME decoders, which use the same boundary matching pattern.
Fix
Require MIME boundaries to start at the beginning of a line and validate the bytes following the boundary name. Valid line endings, optional transport padding, and closing boundary markers are accepted; boundary prefixes and body text are left untouched.
Apply the check consistently to multipart parsing, Base64 decoding, quoted-printable decoding, and malformed-message recovery.
Add regression coverage for mid-line boundary-like text, boundary prefixes, valid closing boundaries, and the existing malformed multipart fixtures.
Closes #156
Testing
cargo testcargo clippy --all-targets --all-features -- -D warningsgit diff --check