Skip to content
This repository was archived by the owner on Nov 4, 2024. It is now read-only.

Patched the loader for files with .js extension#877

Open
compile-this wants to merge 4 commits intostandard-things:masterfrom
compile-this:feature/patch-module-loader-for-mixed-cjs-esm-dependency-graphs
Open

Patched the loader for files with .js extension#877
compile-this wants to merge 4 commits intostandard-things:masterfrom
compile-this:feature/patch-module-loader-for-mixed-cjs-esm-dependency-graphs

Conversation

@compile-this
Copy link

@compile-this compile-this commented May 7, 2020

This prevents the new default behaviour in Node 12+ of erroring when importing dependencies with commonjs syntax files from an ESM module.

See issue #868

@compile-this
Patched the loader for files with .js extension, preventing the default
dde90ad 
behaviour of erroring when importing dependencies with commonjs syntax files
@compile-this
Update @babel/preset-env package
a96bf1f
@compile-this
update @babel-prefix version
6e76351 
to remove warning about out of date dependencies
@compile-this
skip --check tests in Node 12+
2640c85 
node code paths for this functionality have changed and no longer
involve the patched loaders
@seanCodes seanCodes mentioned this pull request Jul 14, 2020
Open
@niksy
Copy link

niksy commented Jan 14, 2021

What is the status of this PR? What can we do to get this merged?

niksy added a commit to niksy/node-sass-json-functions that referenced this pull request Jan 14, 2021
@niksy
Use lower lodash version because of ESM bug
b209826 
Ref. https://github.com/lodash/lodash/issues/5033
Ref. standard-things/esm#868
Ref. standard-things/esm#877
michaelfig added a commit to agoric-labs/esm that referenced this pull request May 16, 2021
@michaelfig
fix: implement standard-things#877
8db4b72
This was referenced May 16, 2021
Merged
Closed
Merged
@mk-pmb
Copy link
Contributor

mk-pmb commented May 31, 2021 •
edited
Loading

@niksy Currently, the CI tests fail, so someone would need to fix those.
I also installed it locally and had the same error as in #898.

Markiz9999 pushed a commit to irls/esm that referenced this pull request Sep 17, 2021
fix: implement standard-things#877
18b1801
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@compile-this @niksy @mk-pmb