Exclude models-snapshot.js from telemetry verification#25
Merged
standardnguyen merged 1 commit intomainfrom Apr 14, 2026
Merged
Exclude models-snapshot.js from telemetry verification#25standardnguyen merged 1 commit intomainfrom
standardnguyen merged 1 commit intomainfrom
Conversation
The build generates models-snapshot.js (not .ts) containing provider metadata with models.dev URLs. The exclude list only had .ts, so verify-clean and check-source would fail after a local build. Fixes #23 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
standardnguyen
approved these changes
Apr 14, 2026
standards-bot-lola
pushed a commit
that referenced
this pull request
Apr 14, 2026
Instead of excluding models-snapshot.js/ts and models-api.json from the telemetry scan (which creates blind spots), remove models.dev from the domain list and verify the strip directly: grep for the "Stripped: no remote model catalog fetch" sentinel in models.ts refresh(). This matches the approach check-binary.sh already uses (BANNED_DOMAINS_STRICT excludes models.dev with the same rationale). Now all three scan scripts are consistent. Supersedes #25. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--exclude=models-snapshot.jstoEXCLUDE_ARGSin bothscripts/verify-clean.shandtests/static/check-source.shmodels-snapshot.js(not.ts) containing provider metadata withmodels.devURLs. The existing exclude only had.ts, so both scripts would fail after a local build.Fixes #23