Repository navigation
Removed checks against symlinks causing errors when running on Wine - #124
Merged
Merged
Conversation
stanuwu
force-pushed
the
fix/wine-sdk
branch
from
September 27, 2026 16:10
a1aa415 to
55c5cb5
Compare
Owner
|
Merged, thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Under wine, not only is Z:\ a reparse point, but also Z:\home
The current system introduced in #101 does not handle that case leading to sdk generation failing on wine if the d2 install is anywhere within /home (aka where most users would have it)
This change is a bit more wide, it reverts #101 and removes most checks against symbolic links (one exception is remove_tree, to not follow symbolic links)
I couldn't find any reason behind most of the other checks against symlinks, and i've ensured that following symlinks in theses conditions cannot lead to deletion of arbitrary files